Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/issue 205 #207

Merged
merged 16 commits into from
Oct 8, 2020
Merged

Fix/issue 205 #207

merged 16 commits into from
Oct 8, 2020

Conversation

mdeceglie
Copy link
Collaborator

@mdeceglie mdeceglie commented Oct 5, 2020 •
edited
Loading

Our previous version of soiling.annual_soiling_ratios() was not properly calculating the irradiance-weighted soiling ratio. (See #205)

  • Code changes are covered by tests
  • New functions added to __init__.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • Updated changelog

@mdeceglie mdeceglie changed the base branch from master to development October 5, 2020 19:32
kandersolar
kandersolar reviewed Oct 6, 2020
View reviewed changes
setup.py Outdated Show resolved Hide resolved
docs/sphinx/source/changelog/pending.rst Outdated Show resolved Hide resolved
rdtools/soiling.py Outdated Show resolved Hide resolved
rdtools/soiling.py Outdated Show resolved Hide resolved
rdtools/soiling.py Show resolved Hide resolved
docs/degradation_and_soiling_example_pvdaq_4.ipynb Show resolved Hide resolved
kandersolar
kandersolar approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A couple minor comments on the tests

rdtools/test/soiling_test.py Outdated Show resolved Hide resolved
rdtools/test/soiling_test.py Outdated Show resolved Hide resolved
@mdeceglie mdeceglie merged commit e85ed0a into development Oct 8, 2020
@mdeceglie mdeceglie deleted the fix/issue_205 branch October 8, 2020 03:36
@kandersolar kandersolar added this to the Version 2 milestone Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kandersolar kandersolar kandersolar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 2
Development

Successfully merging this pull request may close these issues.
2 participants
@mdeceglie @kandersolar